WIP: Add suport for Amphp PSR18 Client #257
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: the use Amp\Http\Client\Psr7\PsrHttpClient is still a WIP, and the support for PSR-18 has been added only on the v2 branch Only on that branch the PsrHttpClient is implementing the ClientInterface Note: The library only supports the psr/http-message:v1 contract
thePanz
force-pushed
the
add-support-amphp-client
branch
from
d3ef842 to
a232679
Compare
|
Linked PR is now merged. Until amphp/http-client-psr7#10 (comment) is resolved, this should also install guzzle's PSR-7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: the use Amp\Http\Client\Psr7\PsrHttpClient is still a WIP, and the support for PSR-18 has been added only on the v2 branch
Only on that branch the PsrHttpClient is implementing the ClientInterface
Note: The library only supports the psr/http-message:v1 contract
What's in this PR?
Implement support for amphp/http-client-psr7
Some notes:
v2.xbranch is effectively implements the PSR ClientInterface, but relies on psr/http-message v1masterlast commit: 3 years ago,v2.xlast commit: 2 years ago)Checklist
To Do
Composer/Plugin.phpaccording to the documentation, by adding amphp/http-client-psr7